-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add gcloud module #1493
feat: Add gcloud module #1493
Conversation
Signed-off-by: dulltz <isrgnoe@gmail.com>
Signed-off-by: dulltz <isrgnoe@gmail.com>
Signed-off-by: dulltz <isrgnoe@gmail.com>
11f359d
to
9fe406d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I am not a Rust dev so do not read .rs
often. Perhaps await another review
starship#1493 Signed-off-by: dulltz <isrgnoe@gmail.com>
The workflow failed on the unrelated modules. https://github.com/starship/starship/runs/897666161?check_suite_focus=true
https://github.com/starship/starship/runs/897666170?check_suite_focus=true
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
@dulltz, thank you for your contribution and thank you @jthegedus for reviewing. |
* feat(gcloud): Add document of gcloud module Signed-off-by: dulltz <isrgnoe@gmail.com> * feat(gcloud): Add gcloud module Signed-off-by: dulltz <isrgnoe@gmail.com> * feat(gcloud): Add test for gcloud module Signed-off-by: dulltz <isrgnoe@gmail.com> * Apply the comment starship#1493 Signed-off-by: dulltz <isrgnoe@gmail.com>
* feat(gcloud): Add document of gcloud module Signed-off-by: dulltz <isrgnoe@gmail.com> * feat(gcloud): Add gcloud module Signed-off-by: dulltz <isrgnoe@gmail.com> * feat(gcloud): Add test for gcloud module Signed-off-by: dulltz <isrgnoe@gmail.com> * Apply the comment starship#1493 Signed-off-by: dulltz <isrgnoe@gmail.com>
Description
Add a module for displaying the current
gcloud
profile based on the followings:~/.config/gcloud/active_config
~/.config/gcloud/configurations/config_$(cat ~/.config/gcloud/active_config)
CLOUDSDK_CONFIG
env varThis module is based on the AWS module.
Motivation and Context
Fixes #901
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: