Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gcloud module #1493

Merged
merged 5 commits into from
Aug 3, 2020
Merged

feat: Add gcloud module #1493

merged 5 commits into from
Aug 3, 2020

Conversation

dulltz
Copy link
Contributor

@dulltz dulltz commented Jul 19, 2020

Description

Add a module for displaying the current gcloud profile based on the followings:

  • ~/.config/gcloud/active_config
  • ~/.config/gcloud/configurations/config_$(cat ~/.config/gcloud/active_config)
  • CLOUDSDK_CONFIG env var

This module is based on the AWS module.

Motivation and Context

Fixes #901

Screenshots (if appropriate):

gcloud-module

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Signed-off-by: dulltz <isrgnoe@gmail.com>
Signed-off-by: dulltz <isrgnoe@gmail.com>
@dulltz dulltz mentioned this pull request Jul 19, 2020
Signed-off-by: dulltz <isrgnoe@gmail.com>
Copy link

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I am not a Rust dev so do not read .rs often. Perhaps await another review

docs/config/README.md Outdated Show resolved Hide resolved
@andytom andytom requested a review from a team July 20, 2020 12:56
starship#1493
Signed-off-by: dulltz <isrgnoe@gmail.com>
@dulltz
Copy link
Contributor Author

dulltz commented Jul 22, 2020

The workflow failed on the unrelated modules.
It might be unrelated to this PR, so would someone rerun the workflow?

https://github.com/starship/starship/runs/897666161?check_suite_focus=true

failures:
    modules::golang::tests::folder_with_gopkg_lock
    modules::golang::tests::folder_with_gopkg_yml
    modules::julia::tests::folder_with_manifest_toml
    modules::julia::tests::folder_with_project_toml

https://github.com/starship/starship/runs/897666170?check_suite_focus=true

failures:
    modules::crystal::tests::folder_with_shard_file

Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@andytom andytom merged commit c5f2eed into starship:master Aug 3, 2020
@andytom
Copy link
Member

andytom commented Aug 3, 2020

@dulltz, thank you for your contribution and thank you @jthegedus for reviewing.

@dulltz dulltz deleted the feat/gcloud_module branch August 5, 2020 14:48
chipbuster pushed a commit to chipbuster/starship that referenced this pull request Jan 14, 2021
* feat(gcloud): Add document of gcloud module

Signed-off-by: dulltz <isrgnoe@gmail.com>

* feat(gcloud): Add gcloud module

Signed-off-by: dulltz <isrgnoe@gmail.com>

* feat(gcloud): Add test for gcloud module

Signed-off-by: dulltz <isrgnoe@gmail.com>

* Apply the comment

starship#1493
Signed-off-by: dulltz <isrgnoe@gmail.com>
dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
* feat(gcloud): Add document of gcloud module

Signed-off-by: dulltz <isrgnoe@gmail.com>

* feat(gcloud): Add gcloud module

Signed-off-by: dulltz <isrgnoe@gmail.com>

* feat(gcloud): Add test for gcloud module

Signed-off-by: dulltz <isrgnoe@gmail.com>

* Apply the comment

starship#1493
Signed-off-by: dulltz <isrgnoe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcloud config
3 participants